hobokenchicken/GopherGate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(openai): map system to developer role and enhance stream diagnostics for Responses API
Some checks failed
CI / Check (push) Has been cancelled
Details
CI / Clippy (push) Has been cancelled
Details
CI / Formatting (push) Has been cancelled
Details
CI / Test (push) Has been cancelled
Details
CI / Release Build (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Dustin Newkirk
2026-03-17 18:50:55 +00:00
parent b131094dfd
commit 78fff61660
1 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/providers/openai.rs
View File

@@ -112,7 +112,12 @@ impl super::Provider for OpenAIProvider {
let messages_json = helpers::messages_to_openai_json(&request.messages).await?; let messages_json = helpers::messages_to_openai_json(&request.messages).await?;
let mut input_parts = Vec::new(); let mut input_parts = Vec::new();
for m in &messages_json { for m in &messages_json {
let role = m["role"].as_str().unwrap_or("user"); let mut role = m["role"].as_str().unwrap_or("user").to_string();
// Newer models (gpt-5, o1) prefer "developer" over "system"
if role == "system" {
role = "developer".to_string();
}
let mut content = m.get("content").cloned().unwrap_or(serde_json::json!([])); let mut content = m.get("content").cloned().unwrap_or(serde_json::json!([]));
// Map content types based on role for Responses API // Map content types based on role for Responses API
@@ -374,7 +379,12 @@ impl super::Provider for OpenAIProvider {
let messages_json = helpers::messages_to_openai_json(&request.messages).await?; let messages_json = helpers::messages_to_openai_json(&request.messages).await?;
let mut input_parts = Vec::new(); let mut input_parts = Vec::new();
for m in &messages_json { for m in &messages_json {
let role = m["role"].as_str().unwrap_or("user"); let mut role = m["role"].as_str().unwrap_or("user").to_string();
// Newer models (gpt-5, o1) prefer "developer" over "system"
if role == "system" {
role = "developer".to_string();
}
let mut content = m.get("content").cloned().unwrap_or(serde_json::json!([])); let mut content = m.get("content").cloned().unwrap_or(serde_json::json!([]));
// Map content types based on role for Responses API // Map content types based on role for Responses API
@@ -515,21 +525,22 @@ impl super::Provider for OpenAIProvider {
let probe_resp = probe_client let probe_resp = probe_client
.post(&url) .post(&url)
.header("Authorization", format!("Bearer {}", api_key)) .header("Authorization", format!("Bearer {}", api_key))
.header("Accept", "application/json") // Ask for JSON during probe
.json(&probe_body) .json(&probe_body)
.send() .send()
.await; .await;
match probe_resp { match probe_resp {
Ok(r) if !r.status().is_success() => { Ok(r) => {
let status = r.status(); let status = r.status();
let error_body = r.text().await.unwrap_or_default(); let body = r.text().await.unwrap_or_default();
tracing::error!("OpenAI Responses Stream Error Probe ({}): {}", status, error_body); if status.is_success() {
Err(AppError::ProviderError(format!("OpenAI Responses API error ({}): {}", status, error_body)))?; tracing::warn!("Responses stream ended prematurely but probe returned 200 OK. Body: {}", body);
} Err(AppError::ProviderError(format!("Responses stream ended (server sent 200 OK with body: {})", body)))?;
Ok(_) => { } else {
// If the probe returned 200, but the stream ended, it might be a silent failure or timeout. tracing::error!("OpenAI Responses Stream Error Probe ({}): {}", status, body);
tracing::warn!("Responses stream ended prematurely (probe returned 200). Error: {}", e); Err(AppError::ProviderError(format!("OpenAI Responses API error ({}): {}", status, body)))?;
Err(AppError::ProviderError(format!("Responses stream error (connection closed by server after 200 OK): {}", e)))?; }
} }
Err(probe_err) => { Err(probe_err) => {
tracing::error!("OpenAI Responses Stream Error Probe failed: {}", probe_err); tracing::error!("OpenAI Responses Stream Error Probe failed: {}", probe_err);