From f6f63ecd2b137a4ace1e4b89f23f34210ac45fc8 Mon Sep 17 00:00:00 2001 From: hobokenchicken Date: Thu, 2 Jul 2026 13:21:17 -0400 Subject: [PATCH] fix: pass GIT_SHA inline to npm run build The export-then-chain wasn't propagating into the subshell. Use Make variable and pass GIT_SHA= directly to the command. --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 875ba61..cd6c77c 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,8 @@ SHELL := /bin/bash .PHONY: build build-web build-server build-tui run run-tui dev docker-up docker-down clean +GIT_SHA := $(shell git rev-parse --short HEAD) + # Build everything build: build-web build-server @@ -18,7 +20,7 @@ docs: # Build the web frontend build-web: - cd web && export GIT_SHA=$$(git rev-parse --short HEAD) && ([ -s ~/.nvm/nvm.sh ] && . ~/.nvm/nvm.sh && npm run build || npm run build) + cd web && ([ -s ~/.nvm/nvm.sh ] && . ~/.nvm/nvm.sh && GIT_SHA=$(GIT_SHA) npm run build || GIT_SHA=$(GIT_SHA) npm run build) # Run the server locally (dev mode) run: build-server