LobotomyLabs/dumpsterChat
2
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 1 Wiki Activity

fix: use window.addEventListener for dropdown keyboard nav

Browse Source 
inputRef-based listener never fired (ref null at effect time or
element-level listeners don't catch events in this React setup).
Switched to window.addEventListener matching the pattern every other
keyboard handler in this codebase already uses.
This commit is contained in:
Dustin Newkirk
2026-07-02 13:03:41 -04:00
parent 4ed2e5bfd0
commit 3002626ac4
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/components/ChatArea.tsx
+3 -5
View File
@@ -495,10 +495,8 @@ export function ChatArea() {
inputEl.setSelectionRange(pos, pos); inputEl.setSelectionRange(pos, pos);
}; };
// ponytail: stable keydown handler via addEventListener avoids stale closure issues // ponytail: window listener matches existing pattern in codebase (CommandDropdown, modals)
useEffect(() => { useEffect(() => {
const el = inputRef.current;
if (!el) return;
const handler = (e: KeyboardEvent) => { const handler = (e: KeyboardEvent) => {
if (e.ctrlKey && e.key === 'e') { if (e.ctrlKey && e.key === 'e') {
e.preventDefault(); e.preventDefault();
@@ -568,8 +566,8 @@ export function ChatArea() {
setDropdownIndex(0); setDropdownIndex(0);
} }
}; };
el.addEventListener('keydown', handler); window.addEventListener('keydown', handler);
return () => el.removeEventListener('keydown', handler); return () => window.removeEventListener('keydown', handler);
}, [members, currentUser, activeChannelId, sendMessage, replyToMessage, handleMentionSelect]); }, [members, currentUser, activeChannelId, sendMessage, replyToMessage, handleMentionSelect]);
const handleSubmit = async (event: React.FormEvent) => { const handleSubmit = async (event: React.FormEvent) => {