🚨 Fixed DeepSource issues

classquiz/config.py

@@ -71,6 +71,7 @@ class Settings(BaseSettings):
 
 
 async def initialize_arq():
+    # skipcq: PYL-W0603
     global arq
     arq = await create_pool(RedisSettings.from_dsn(settings.redis))
 
@@ -80,8 +81,6 @@ def settings() -> Settings:
     return Settings()
 
 
-# asyncio.run(initialize_arq())
-
 pool = redis_lib.ConnectionPool().from_url(settings().redis)
 
 redis: redis_base_lib.client.Redis = redis_lib.Redis(connection_pool=pool)

classquiz/db/models.py

@@ -297,7 +297,7 @@ class GameInLobby(BaseModel):
     game_id: uuid.UUID
 
 
-#
+# skipcq: PY-W0069
 # class UserProfileLinks(ormar.Model):
 #     id: int = ormar.Integer(primary_key=True, autoincrement=True)
 #     user: Optional[User] = ormar.ForeignKey(User)

classquiz/db/quiztivity.py

@@ -41,10 +41,3 @@ class QuizTivityPage(BaseModel):
     title: str | None
     type: QuizTivityTypes
     data: Pdf | Memory | Markdown
-
-    # @validator("type")
-    # def match_type_to_data_type(cls, v, values, **kwargs):
-    #     print(values)
-    #     if TYPE_CLASS_LIST[v] != type(values["data"]):
-    #         raise ValueError("Specified Type doesn't match real data type")
-    #     pass

classquiz/oauth/custom.py

@@ -88,8 +88,9 @@ async def auth(request: Request, response: Response):
                 google_uid=user_data.sub.hex,
                 avatar=gzipped_user_avatar(),
             )
+        # skipcq: PYL-W0703
         except Exception as e:
-            if type(e) == asyncpg.exceptions.UniqueViolationError:
+            if type(e) is asyncpg.exceptions.UniqueViolationError:
                 error = True
                 counter = 1
                 while error:

classquiz/oauth/github.py

@@ -116,8 +116,9 @@ async def auth(request: Request, response: Response):
                 auth_type=UserAuthTypes.GITHUB,
                 avatar=gzipped_user_avatar(),
             )
+        # skipcq: PYL-W0703
         except Exception as e:
-            if type(e) == asyncpg.exceptions.UniqueViolationError:
+            if type(e) is asyncpg.exceptions.UniqueViolationError:
                 error = True
                 counter = 1
                 while error:

classquiz/oauth/google.py

@@ -90,8 +90,9 @@ async def auth(request: Request, response: Response):
                 google_uid=user_data.sub,
                 avatar=gzipped_user_avatar(),
             )
+        # skipcq: PYL-W0703
         except Exception as e:
-            if type(e) == asyncpg.exceptions.UniqueViolationError:
+            if type(e) is asyncpg.exceptions.UniqueViolationError:
                 error = True
                 counter = 1
                 while error:

classquiz/routers/avatar.py

@@ -80,6 +80,7 @@ async def get_customized_avatar(
         clothe_color=clothe_color,
         clothe_graphic_type=clothe_graphic_type,
     ).render_svg()
+    # skipcq: PY-W0069
     # print(f"skin_color: {len(AvatarItemsAsList.skin_color)},")
     # print(f"hair_color: {len(AvatarItemsAsList.hair_color)},")
     # print(f"facial_hair_type: {len(AvatarItemsAsList.facial_hair_type)},")

classquiz/routers/box_controller/embedded.py

@@ -109,7 +109,7 @@ button_to_index_map = {"b": 0, "g": 1, "y": 2, "r": 3}
 @router.websocket("/socket/{id}")
 async def websocket_endpoint(ws: WebSocket, game_id: str, id: str):
     try:
-        if id in wss_clients.keys():
+        if id in wss_clients:
             await ws.close(code=status.WS_1001_GOING_AWAY)
             print("Client {} already exists.".format(id))
             return

classquiz/routers/box_controller/web.py

@@ -26,7 +26,7 @@ def generate_code() -> str:
         "r",
     ]  # Capital stands for long press, lowercase letter for short press
     resulting_code = ""
-    for i in range(specified_length):
+    for _ in range(specified_length):
         resulting_code += random.choice(buttons)
     return resulting_code
 

classquiz/routers/editor.py

@@ -106,9 +106,6 @@ async def finish_edit(edit_id: str, quiz_input: QuizInput):
     if quiz_input.cover_image == "":
         quiz_input.cover_image = None
 
-    # if quiz_input.background_image is None and old_quiz_data.background_image is not None:
-    #     mark_image_for_deletion(quiz_input.background_image)
-
     if quiz_input.cover_image is not None and not check_image_string(quiz_input.cover_image)[0]:
         raise HTTPException(status_code=400, detail="image url is not valid")
 

classquiz/routers/eximport.py

@@ -46,9 +46,8 @@ async def export_quiz(quiz_id: uuid.UUID, user: User = Depends(get_current_user)
     quiz_dict["updated_at"] = quiz_dict["updated_at"].isoformat()
     quiz_json = json.dumps(quiz_dict)
     bin_data = gzip.compress(quiz_json.encode("utf-8"), compresslevel=9)
-    # bin_data = quiz_json.encode("utf-8")
     bin_data = bin_data + quiz_delimiter
-    for image_key in image_urls.keys():
+    for image_key in image_urls:
         bin_data = bin_data + image_delimiter + str(image_key).encode("utf-8") + image_index_delimiter
         image_data = None
         async with ClientSession() as session, session.get(

classquiz/routers/live.py

@@ -134,8 +134,6 @@ async def get_live_game_data(
 
 @router.get("/user_count")
 async def get_game_user_count(game_pin: str, api_key: str, as_string: bool = False, as_array: bool = False):
-    # if redis_res is None:
-    #     raise HTTPException(status_code=404, detail="Game not found")
     user_id = await check_api_key(api_key)
     redis_res = await redis.get(f"game_session:{game_pin}")
     if redis_res is None:
@@ -149,12 +147,6 @@ async def get_game_user_count(game_pin: str, api_key: str, as_string: bool = Fal
         return {"players": {"count": player_count}}
 
 
-# class _LivePlayersReturn(BaseModel):
-#     # players: list[GamePlayer | None]
-#     answers: list[GameAnswer1 | None]
-#     players: list[GamePlayer | None]
-
-
 @router.get(
     "/players",
 )

classquiz/routers/login.py

@@ -149,7 +149,7 @@ class StepInput(BaseModel):
 
 
 @router.post("/step/{step_id}")
-async def step_1(session_id: str, data: StepInput, request: Request, response: Response, step_id: int):
+async def step_1_endpoint(session_id: str, data: StepInput, request: Request, response: Response, step_id: int):
     if step_id < 0 or step_id > 2:
         raise HTTPException(status_code=401)
     redis_res = await redis.get(f"login_session:{session_id}")

classquiz/routers/quiz.py

@@ -83,7 +83,7 @@ def generate_code() -> str:
         "r",
     ]  # Capital stands for long press, lowercase letter for short press
     resulting_code = ""
-    for i in range(specified_length):
+    for _ in range(specified_length):
         resulting_code += random.choice(buttons)
     return resulting_code
 

classquiz/routers/results.py

@@ -49,6 +49,7 @@ async def set_note(id: UUID, data: _SetNoteInput, user: User = Depends(get_curre
     return await res.update()
 
 
+# skipcq: PYL-W0105
 """
 @router.get("/export/{result_id}", response_class=StreamingResponse)
 async def export_result(result_id: UUID, user: User = Depends(get_current_user)):

classquiz/routers/storage.py

@@ -221,7 +221,6 @@ async def list_images(
         raise HTTPException(status_code=404, detail="No items found")
     return_items: list[PrivateStorageItem] = []
     for item in storage_items:
-        # print(item.quizzes)
         return_items.append(PrivateStorageItem.from_db_model(item))
     return return_items
 

classquiz/routers/users/__init__.py

@@ -79,7 +79,6 @@ async def create_user(user: RouteUser, background_task: BackgroundTasks) -> User
     if len(user.username) == 32:
         return JSONResponse({"details": "Username mustn't be 32 characters long"}, 400)
     await user.save()
-    # print(settings.skip_email_verification)
     if settings.skip_email_verification:
         user.verify_key = None
         user.verified = True

classquiz/socket_server/__init__.py

@@ -253,7 +253,7 @@ class ReturnQuestion(QuizQuestion):
         if values["type"] == QuizQuestionType.RANGE and type(v) != RangeQuizAnswerWithoutSolution:
             raise ValueError("Answer must be from type RangeQuizAnswer if type is RANGE")
         if values["type"] == QuizQuestionType.VOTING and type(v[0]) != VotingQuizAnswer:
-            # print("Answer must be from type VotingQuizAnswer if type is VOTING")
+            # skipcq: PTC-W0047
             pass
         return v
 
@@ -262,7 +262,6 @@ class ReturnQuestion(QuizQuestion):
 async def set_question_number(sid, data: str):
     # data is just a number (as a str) of the question
     session = await sio.get_session(sid)
-    # print("set_question_number", data, session)
     if session["admin"]:
         game_pin = session["game_pin"]
         game_data = PlayGame.parse_raw(await redis.get(f"game:{session['game_pin']}"))
@@ -286,7 +285,6 @@ async def set_question_number(sid, data: str):
         temp_return["type"] = game_data.questions[int(float(data))].type
         if temp_return["type"] == QuizQuestionType.ORDER:
             random.shuffle(temp_return["answers"])
-        # print("emitting")
         await sio.emit(
             "set_question_number",
             {
@@ -375,8 +373,6 @@ async def submit_answer(sid: str, data: dict):
     answers = await redis.get(f"game_session:{session['game_pin']}:{data.question_index}")
     diff = (time_q_started - now).total_seconds() * 1000  # - timedelta(milliseconds=latency)
 
-    # print(abs(diff) - latency, latency, abs(diff))
-
     score = 0
     if answer_right:
         score = calculate_score(

classquiz/storage/local_storage.py

@@ -27,9 +27,10 @@ class LocalStorage:
         except FileNotFoundError:
             yield None
 
-    async def upload(self, file_name: str, data: BinaryIO, mime_type: str | None = None) -> None:
+    # skipcq: PYL-W0613
+    async def upload(self, file_name: str, file: BinaryIO, mime_type: str | None = None) -> None:
         async with aiofiles.open(file=os.path.join(self.base_path, file_name), mode="wb") as f:
-            await aioshutil_copyfileobj(data, f)
+            await aioshutil_copyfileobj(file, f)
 
     async def delete(self, file_names: [str]) -> None:
         for i in file_names:

classquiz/storage/s3_storage.py

@@ -103,15 +103,13 @@ class S3Storage:
             + "Signature="
             + signature
         )
-        # if expiry is not None:
-        #     authorization_header += f", Expires={expiry}"
-
         # Send the request with the authorization header
         headers = {"x-amz-date": amz_date, "Authorization": authorization_header}
         request_url = self.base_url + path + "?" + canonical_querystring
 
         return headers, request_url
 
+    # skipcq: PYL-W0613
     async def upload(self, file: BinaryIO, file_name: str, mime_type: str | None = "application/octet-stream") -> None:
         headers, url = self._generate_aws_signature_v4(method="PUT", path=f"/{file_name}")
         async with ClientSession() as session, session.put(url, headers=headers, data=file) as resp:

classquiz/worker/storage.py

@@ -16,6 +16,7 @@ from classquiz.storage.errors import DeletionFailedError
 from thumbhash import image_to_thumbhash
 
 
+# skipcq: PYL-W0613
 async def clean_editor_images_up(ctx):
     print("Cleaning images up")
     edit_sessions = await redis.smembers("edit_sessions")
@@ -52,10 +53,12 @@ async def calculate_hash(ctx, file_id_as_str: str):
     try:
         if 0 < file_data.size < 20_970_000:  # greater than 0 but smaller than 20mbytes
             file_data.thumbhash = image_to_thumbhash(file)
+    # skipcq: PYL-W0703
     except Exception:
         pass
     hash_obj = xxhash.xxh3_128()
 
+    # skipcq: PY-W0069
     # assert hash_obj.block_size == 64
     while chunk := file.read(6400):
         hash_obj.update(chunk)
@@ -70,6 +73,7 @@ async def calculate_hash(ctx, file_id_as_str: str):
     await user.update()
 
 
+# skipcq: PYL-W0613
 async def quiz_update(ctx, old_quiz: Quiz, quiz_id: uuid.UUID):
     new_quiz: Quiz = await Quiz.objects.get(id=quiz_id)
     old_images = extract_image_ids_from_quiz(old_quiz)
@@ -83,8 +87,6 @@ async def quiz_update(ctx, old_quiz: Quiz, quiz_id: uuid.UUID):
     removed_images = list(set(old_images) - set(new_images))
     added_images = list(set(new_images) - set(old_images))
     change_made = False
-    # print("added:", added_images)
-    # print("removed:", removed_images)
     for image in removed_images:
         if "--" in image:
             await storage.delete([image])
@@ -92,7 +94,6 @@ async def quiz_update(ctx, old_quiz: Quiz, quiz_id: uuid.UUID):
             item = await StorageItem.objects.get_or_none(id=uuid.UUID(image))
             if item is None:
                 continue
-            # print("removed item")
             try:
                 await new_quiz.storageitems.remove(item)
             except ormar.exceptions.NoMatch:
@@ -103,7 +104,6 @@ async def quiz_update(ctx, old_quiz: Quiz, quiz_id: uuid.UUID):
             item = await StorageItem.objects.get_or_none(id=uuid.UUID(image))
             if item is None:
                 continue
-            # print("added item")
             await new_quiz.storageitems.add(item)
             change_made = True
     if change_made: