From caa2a6002f433fd2f82ac373e34d04bf31a2cb58 Mon Sep 17 00:00:00 2001 From: Mawoka Date: Sat, 25 Oct 2025 22:49:02 +0200 Subject: [PATCH] Bug fixes and correct answer count in results --- classquiz/socket_server/__init__.py | 6 ++-- classquiz/socket_server/helpers.py | 18 +++++------- .../src/lib/components/buttons/brown.svelte | 16 ++++------ .../src/lib/components/buttons/gray.svelte | 12 ++++---- frontend/src/lib/editor/card.svelte | 12 ++++---- frontend/src/lib/editor/sidebar.svelte | 2 +- frontend/src/lib/editor/uploader.svelte | 10 +++---- .../src/lib/editor/uploader/Library.svelte | 2 +- .../src/lib/editor/uploader/Pixabay.svelte | 6 ++-- frontend/src/lib/i18n/locales/de.json | 3 +- frontend/src/lib/i18n/locales/en.json | 3 +- .../lib/play/admin/game_not_started.svelte | 9 ++---- frontend/src/lib/play/join.svelte | 13 +++++++-- frontend/src/lib/play/question.svelte | 24 +++++++-------- frontend/src/lib/play/questions/check.svelte | 9 +++--- frontend/src/lib/practice/question.svelte | 7 +++-- .../quiztivity/components/abcd/edit.svelte | 2 +- .../quiztivity/components/memory/edit.svelte | 6 ++-- frontend/src/lib/quiztivity/editor.svelte | 18 ++++++------ .../src/lib/quiztivity/shares_popover.svelte | 10 +++---- frontend/src/routes/+page.svelte | 2 +- .../controllers/[controller_id]/+page.svelte | 2 +- .../src/routes/account/settings/+page.svelte | 4 +-- .../account/settings/avatar/+page.svelte | 8 ++--- .../account/settings/security/+page.svelte | 8 ++--- frontend/src/routes/admin/+page.svelte | 4 +-- frontend/src/routes/dashboard/+page.svelte | 10 +++---- .../src/routes/dashboard/Analytics.svelte | 2 +- frontend/src/routes/edit/files/+page.svelte | 4 +-- frontend/src/routes/edit/videos/+page.svelte | 6 ++-- .../quiztivity/play/navigation_bar.svelte | 4 +-- frontend/src/routes/results/+page.svelte | 2 +- .../routes/results/[result_id]/+page.svelte | 1 + .../[result_id]/general_overview.svelte | 27 +++++++---------- .../[result_id]/player_overview.svelte | 29 +++++++++++++++---- .../src/routes/view/[quiz_id]/+page.svelte | 4 +-- .../routes/view/[quiz_id]/ModComponent.svelte | 16 +++++----- 37 files changed, 164 insertions(+), 157 deletions(-) diff --git a/classquiz/socket_server/__init__.py b/classquiz/socket_server/__init__.py index 30a23b2..52875cc 100644 --- a/classquiz/socket_server/__init__.py +++ b/classquiz/socket_server/__init__.py @@ -216,7 +216,7 @@ async def register_as_admin(sid: str, data: dict): if await redis.get(f"game_session:{game_pin}") is not None: await sio.emit("already_registered_as_admin", room=sid) return - GameSession(admin=sid, game_id=game_id, answers=[]).save(game_pin) + await GameSession(admin=sid, game_id=game_id, answers=[]).save(game_pin) await sio.emit( "registered_as_admin", {"game_id": game_id, "game": await redis.get(f"game:{game_pin}")}, @@ -251,7 +251,7 @@ async def set_question_number(sid: str, data: str): game_data = await PlayGame.get_from_redis(session["game_pin"]) game_data.current_question = int(float(data)) game_data.question_show = True - game_data.save(session["game_pin"]) + await game_data.save(session["game_pin"]) await redis.set(f"game:{session['game_pin']}:current_time", datetime.now().isoformat(), ex=7200) temp_return = game_data.model_dump(include={"questions"})["questions"][int(float(data))] if game_data.questions[int(float(data))].type == QuizQuestionType.SLIDE: @@ -296,7 +296,7 @@ async def submit_answer(sid: str, data: dict): if already_answered: await sio.emit("already_replied", room=sid) return - (answer_right, answer) = check_answer(game_data, data) + answer_right, answer = check_answer(game_data, data) latency = int(float(session["ping"])) time_q_started = datetime.fromisoformat(await redis.get(f"game:{session['game_pin']}:current_time")) diff = (time_q_started - now).total_seconds() * 1000 # - timedelta(milliseconds=latency) diff --git a/classquiz/socket_server/helpers.py b/classquiz/socket_server/helpers.py index 4f19985..d4a2ed9 100644 --- a/classquiz/socket_server/helpers.py +++ b/classquiz/socket_server/helpers.py @@ -30,7 +30,6 @@ async def check_captcha(captcha_data: str) -> bool: ) as resp: resp_data = await resp.model_dump_json() if not resp_data["success"]: - print("CAPTCHA FAILED") return except KeyError: return False @@ -60,7 +59,7 @@ def check_answer(game_data: PlayGame, data: SubmitAnswerData) -> (bool, str): q_answers = game_data.questions[q_i].answers q_answer = data.answer if q_type == QuizQuestionType.ABCD: - return (check_abcd_question, data.answer) + return (check_abcd_question(q_answer, q_answers), data.answer) elif q_type == QuizQuestionType.RANGE: return ( check_range_question(q_answer, q_answers), @@ -69,7 +68,7 @@ def check_answer(game_data: PlayGame, data: SubmitAnswerData) -> (bool, str): elif q_type == QuizQuestionType.VOTING: return (False, q_answer) elif q_type == QuizQuestionType.ORDER: - return check_order_question(q_answer, q_answers) + return check_order_question(data.complex_answer, q_answer, q_answers) elif q_type == QuizQuestionType.TEXT: return ( check_text_question(q_answer, q_answers), @@ -105,14 +104,11 @@ def check_order_question( ) -> (bool, str): if complex_answer is None: return (False, answer) - correct_answers = [] - for a in answers: - correct_answers.append({"answer": a.answer}) - answer_order = [] - for a in complex_answer.model_dump(): - answer_order.append(a["answer"]) - answer = ", ".join(answer_order) - return (correct_answers == complex_answer.model_dump(), answer) + correct_answers = [{"answer": a.answer} for a in answers] + submitted_answers = [{"answer": a.answer} for a in complex_answer] + answer_str = ", ".join(a["answer"] for a in submitted_answers) + is_correct = submitted_answers == correct_answers + return is_correct, answer_str def check_text_question(answer: str, answers: list[TextQuizAnswer]) -> bool: diff --git a/frontend/src/lib/components/buttons/brown.svelte b/frontend/src/lib/components/buttons/brown.svelte index b9f4962..7a2846a 100644 --- a/frontend/src/lib/components/buttons/brown.svelte +++ b/frontend/src/lib/components/buttons/brown.svelte @@ -5,19 +5,14 @@ SPDX-License-Identifier: MPL-2.0 --> @@ -39,7 +35,7 @@ SPDX-License-Identifier: MPL-2.0 class:cursor-not-allowed={disabled} class:pointer-events-none={disabled} class="text-black hover:bg-bg-[#B07156]/80 w-full px-4 py-2 leading-5 transition-all duration-200 transform bg-[#B07156] rounded-sm text-center outline-hidden hover:cursor-pointer" - onclick={bubble('click')} + {onclick} class:flex class:justify-center={flex} > @@ -50,7 +46,7 @@ SPDX-License-Identifier: MPL-2.0 {disabled} {type} class="text-black hover:cursor-pointer hover:opacity-80 w-full px-4 py-2 leading-5 transition-all duration-200 transform bg-[#B07156] rounded-sm text-center focus:outline-hidden disabled:cursor-not-allowed disabled:opacity-50 outline-hidden" - onclick={bubble('click')} + {onclick} class:flex class:justify-center={flex} > diff --git a/frontend/src/lib/components/buttons/gray.svelte b/frontend/src/lib/components/buttons/gray.svelte index 65705a6..3d94a99 100644 --- a/frontend/src/lib/components/buttons/gray.svelte +++ b/frontend/src/lib/components/buttons/gray.svelte @@ -5,16 +5,13 @@ SPDX-License-Identifier: MPL-2.0 --> @@ -31,7 +29,7 @@ SPDX-License-Identifier: MPL-2.0 {href} {target} class="w-full px-4 py-2 leading-5 text-black dark:text-white transition-colors duration-200 transform bg-gray-50 dark:bg-gray-700 rounded-sm text-center hover:bg-gray-300 focus:outline-hidden disabled:cursor-not-allowed disabled:opacity-50 dark:hover:bg-gray-600" - onclick={bubble('click')} + {onclick} class:flex class:block={!flex} class:justify-center={flex} @@ -42,7 +40,7 @@ SPDX-License-Identifier: MPL-2.0