From 3e6e367ed0dbc64d1affb1b91092e8970450df5a Mon Sep 17 00:00:00 2001
From: Mawoka <git@mawoka.eu>
Date: Fri, 30 Jun 2023 18:55:13 +0200
Subject: [PATCH] :rotating_light: Fixed deepsource issues

---
 classquiz/helpers/__init__.py                              | 1 -
 frontend/i18next-scanner.config.engine.cjs                 | 2 +-
 frontend/src/lib/admin.ts                                  | 3 +--
 frontend/src/lib/i18n/translation-service.ts               | 1 +
 frontend/src/routes/+layout.ts                             | 2 +-
 frontend/src/routes/account/oauth-error/+page.ts           | 2 +-
 frontend/src/routes/account/password-reset/+page.server.ts | 2 +-
 frontend/src/routes/admin/+page.server.ts                  | 2 +-
 frontend/src/routes/overview/+server.ts                    | 2 +-
 frontend/src/routes/view/[quiz_id]/+page.server.ts         | 2 +-
 10 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/classquiz/helpers/__init__.py b/classquiz/helpers/__init__.py
index 46b7b1f..ff5013c 100644
--- a/classquiz/helpers/__init__.py
+++ b/classquiz/helpers/__init__.py
@@ -128,7 +128,6 @@ async def meilisearch_init():
     for i in meilisearch.index(settings.meilisearch_index).get_stats():
         number_of_docs = i[1]["numberOfDocuments"]
         break
-    # if meilisearch.index(settings.meilisearch_index).get_stats()["numberOfDocuments"] != quiz_count:
     if number_of_docs != quiz_count:
         print("MeiliSearch and Database got out of sync, syncthing them")
         meilisearch.delete_index(settings.meilisearch_index)
diff --git a/frontend/i18next-scanner.config.engine.cjs b/frontend/i18next-scanner.config.engine.cjs
index a4be2a5..19d7449 100644
--- a/frontend/i18next-scanner.config.engine.cjs
+++ b/frontend/i18next-scanner.config.engine.cjs
@@ -28,7 +28,7 @@ module.exports = {
 
 		// Put a blank string as initial translation
 		// (useful for Weblate be marked as 'not yet translated', see later)
-		defaultValue: (lng, ns, key) => '',
+		defaultValue: () => '',
 
 		// Location of translation files
 		resource: {
diff --git a/frontend/src/lib/admin.ts b/frontend/src/lib/admin.ts
index 6ccf953..e1555cc 100644
--- a/frontend/src/lib/admin.ts
+++ b/frontend/src/lib/admin.ts
@@ -37,8 +37,7 @@ export const getWinnersSorted = (
 			if (q_res === null) {
 				continue;
 			}
-			for (let j = 0; j < q_res.length; j++) {
-				const res = q_res[j];
+			for (const res of q_res) {
 				if (res['right']) {
 					if (winners[res['username']] === undefined) {
 						winners[res['username']] = 0;
diff --git a/frontend/src/lib/i18n/translation-service.ts b/frontend/src/lib/i18n/translation-service.ts
index b263a3c..56b1c60 100644
--- a/frontend/src/lib/i18n/translation-service.ts
+++ b/frontend/src/lib/i18n/translation-service.ts
@@ -29,6 +29,7 @@ export class I18NextTranslationService implements TranslationService {
 	// 2. Create a new set function that changes the i18n locale.
 	// 3. Create a new update function that changes the i18n locale.
 	// 4. Return modified writable.
+	// skipcq: JS-0105
 	private createLocale(i18n: I18nService) {
 		const { subscribe, set, update } = writable<string>(i18n.i18n.language);
 
diff --git a/frontend/src/routes/+layout.ts b/frontend/src/routes/+layout.ts
index 8b71722..32feaf8 100644
--- a/frontend/src/routes/+layout.ts
+++ b/frontend/src/routes/+layout.ts
@@ -6,7 +6,7 @@
 import { signedIn } from '$lib/stores';
 import type { LayoutLoad } from './$types';
 
-export const load: LayoutLoad = async ({ data }) => {
+export const load: LayoutLoad = ({ data }) => {
 	const { email } = data;
 	if (email) {
 		signedIn.set(true);
diff --git a/frontend/src/routes/account/oauth-error/+page.ts b/frontend/src/routes/account/oauth-error/+page.ts
index 1191b0f..8000912 100644
--- a/frontend/src/routes/account/oauth-error/+page.ts
+++ b/frontend/src/routes/account/oauth-error/+page.ts
@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: MPL-2.0
 
-export async function load({ url }) {
+export function load({ url }) {
 	const error = url.searchParams.get('error');
 	return {
 		error
diff --git a/frontend/src/routes/account/password-reset/+page.server.ts b/frontend/src/routes/account/password-reset/+page.server.ts
index 66393dc..321fca6 100644
--- a/frontend/src/routes/account/password-reset/+page.server.ts
+++ b/frontend/src/routes/account/password-reset/+page.server.ts
@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: MPL-2.0
 
-export async function load({ url }) {
+export function load({ url }) {
 	const token = url.searchParams.get('token');
 
 	return {
diff --git a/frontend/src/routes/admin/+page.server.ts b/frontend/src/routes/admin/+page.server.ts
index 837a821..74ef6a8 100644
--- a/frontend/src/routes/admin/+page.server.ts
+++ b/frontend/src/routes/admin/+page.server.ts
@@ -18,6 +18,6 @@ export async function load({ parent, url }) {
 	return {
 		game_pin: pin === null ? '' : pin,
 		game_token: token === null ? '' : token,
-		auto_connect: auto_connect
+		auto_connect
 	};
 }
diff --git a/frontend/src/routes/overview/+server.ts b/frontend/src/routes/overview/+server.ts
index e10d5df..ee29bd9 100644
--- a/frontend/src/routes/overview/+server.ts
+++ b/frontend/src/routes/overview/+server.ts
@@ -4,7 +4,7 @@
 
 import type { RequestHandler } from '@sveltejs/kit';
 
-export const GET: RequestHandler = async () => {
+export const GET: RequestHandler = () => {
 	return new Response(undefined, {
 		status: 301,
 		headers: {
diff --git a/frontend/src/routes/view/[quiz_id]/+page.server.ts b/frontend/src/routes/view/[quiz_id]/+page.server.ts
index 99b921b..27d743e 100644
--- a/frontend/src/routes/view/[quiz_id]/+page.server.ts
+++ b/frontend/src/routes/view/[quiz_id]/+page.server.ts
@@ -13,7 +13,7 @@ export const load = async ({ params, parent }) => {
 	} else if (res.status === 200) {
 		const quiz = await res.json();
 		return {
-			quiz: quiz,
+			quiz,
 			logged_in: Boolean(email)
 		};
 	} else {